NethermindEth / juno

Starknet client implementation.
https://juno.nethermind.io
Apache License 2.0
404 stars 170 forks source link

Add receipt commitment calculation in post07Hash function #2133

Closed kirugan closed 2 months ago

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.37%. Comparing base (37ed095) to head (abfd4cb). Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
core/block.go 75.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2133 +/- ## ========================================== - Coverage 78.41% 78.37% -0.05% ========================================== Files 100 100 Lines 9215 9220 +5 ========================================== Hits 7226 7226 - Misses 1351 1352 +1 - Partials 638 642 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kirugan commented 2 months ago

I think it's safe for now to update only post07Hash function and don't change pre07Hash (it's not used in sepolia)