NethermindEth / juno

Starknet client implementation.
https://juno.nethermind.io
Apache License 2.0
402 stars 170 forks source link

feat: Check for rust version in Makefile #2206

Closed derrix060 closed 1 month ago

derrix060 commented 1 month ago
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.59%. Comparing base (f83a70e) to head (1e6f091). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2206 +/- ## ======================================= Coverage 78.59% 78.59% ======================================= Files 102 102 Lines 9194 9194 ======================================= Hits 7226 7226 Misses 1338 1338 Partials 630 630 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wojciechos commented 1 month ago

Pipeline started to fail because of error: 'cargo msrv' requires a subcommand but one was not provided. Shouldn't it be cargo msrv with find subcommand here?

Yeep, looks like some breaking changes in newest cargo-msrv v0.16 - see here

cargo-msrv v0.16.0 Added cargo msrv find subcommand to determine the MSRV (this subcommand was moved from the top level cargo msrv command to its own subcommand)