search

NethermindEth / juno

Starknet client implementation.
https://juno.nethermind.io
Apache License 2.0
402 stars 170 forks source link

Add missing execution resources to fetched traces #2222

Closed kirugan closed 1 month ago

rianhughes commented 1 month ago

closes https://github.com/NethermindEth/juno/issues/2218 (curious if this will work)

rianhughes commented 1 month ago

LGTM, I'll approve when the tests are fixed

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.40%. Comparing base (b43c46f) to head (ece4df4). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
rpc/trace.go 88.23% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2222 +/- ## ========================================== + Coverage 78.28% 78.40% +0.12% ========================================== Files 103 104 +1 Lines 9325 9333 +8 ========================================== + Hits 7300 7318 +18 + Misses 1377 1366 -11 - Partials 648 649 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.