search

NethermindEth / juno

Starknet client implementation.
https://juno.nethermind.io
Apache License 2.0
402 stars 170 forks source link

Update ResourceBounds to use spec.Uint128 #2242

Closed RuneRogue closed 3 weeks ago

RuneRogue commented 3 weeks ago

Fixing #2237

RuneRogue commented 3 weeks ago

Screenshot 2024-10-27 203256 I need your help . I was trying hard to solve some error but still I was not able to solve this error .
I am getting this error during the test .

RuneRogue commented 3 weeks ago

Screenshot 2024-10-27 203256 I need your help . I was trying hard to solve some error but still I was not able to solve this error . I am getting this error during the test .

@kirugan want your help to solve this issue .

pnowosie commented 3 weeks ago

What is a reason to use p2p/spec/Uint128 in rpc and even worse in the core modules?

I'm against this change, because it puts additional hurdle to client libraries that now would need to handle non-standard integer type. Also p2p/spec/Uint128 is protobuf-specific which should not be used in rpc imo.