search

NethermindEth / near-sffl

https://nffl.nethermind.io/
MIT License
6 stars 3 forks source link

Improve resubscription error handling #196

Closed Hyodar closed 1 month ago

Hyodar commented 1 month ago

This PR makes two small improvements on resubscriptions:

  1. If the subscription didn't fail but the log filtering did, the underlying subscription is still changed
  2. The resub ticker is reset no matter what, as in the end we're rate limiting resubs
Hyodar commented 1 month ago

Agreed. Still, in the end, these weren't total bugs, just not-necessarily-great ideas. I don't think "fix" is the right word here, so changing that, though it's not exactly an improvement either.