NethermindEth / near-sffl

https://nffl.nethermind.io/
MIT License
7 stars 7 forks source link

Investigate log subscription specificities #228

Open Hyodar opened 3 months ago

Hyodar commented 3 months ago

Log subscription seems to be a quite problematic use-case - it's not common, so the support is scarce and we can encounter bugs. There are also some factors such as specific client implementations affecting the expected behavior, such as what seems to be filter timeouts for Geth: https://github.com/ethereum/go-ethereum/blob/bc6569462dfd78394599c93fd9e2a21908aca662/eth/filters/filter_system.go#L47 and the bug we found on unsubscribes in some providers.

We should investigate these details and adapt the SafeEthClient implementation to better handle them.

Keeping this issue for discussion and linking related PRs.