Currently no static analysis tools are being used as part of our build process (either local or CI).
New Behavior
As part of #215, we add golangci-lint as an additional dependency to lint Go files. The linter can be run using make lint.
Breaking Changes
This is not a breaking change since it adds a new Make target without affecting existing ones. Those who want to use the linter will need to add them to their dev enviroments
Observations
This PR also includes some fixes based on the linting results, mostly involving proper error handling (some errors were being ignored).
In the near future we want to:
Address all current linting issues (fix or ignore accordingly)
Current Behavior
Currently no static analysis tools are being used as part of our build process (either local or CI).
New Behavior
As part of #215, we add golangci-lint as an additional dependency to lint Go files. The linter can be run using
make lint.Breaking Changes
This is not a breaking change since it adds a new Make target without affecting existing ones. Those who want to use the linter will need to add them to their dev enviroments
Observations
This PR also includes some fixes based on the linting results, mostly involving proper error handling (some errors were being ignored).
In the near future we want to: