NethermindEth / near-sffl

https://nffl.nethermind.io/
MIT License
7 stars 7 forks source link

Fix block lock copying #275

Closed Hyodar closed 2 months ago

Hyodar commented 3 months ago

Current Behavior

In some cases, geth's types.Block are copied - mostly because of copying our BlockData instances. This is not being problematic in any sense since these locks aren't being used, but it's a small fix anyway.

New Behavior

BlockData now includes a types.Block as a pointer, which is even more ideal considering how much data that struct holds. Thus, no copies even when copying BlockData, which should still be okay.

Breaking Changes

Not a breaking change.