search

NethermindEth / nethermind

A robust execution client for Ethereum node operators.
https://nethermind.io/nethermind-client
GNU General Public License v3.0
1.22k stars 425 forks source link

Handling invalid blocks in Engine API #5760

Open MarekM25 opened 1 year ago

MarekM25 commented 1 year ago

We don't want to reject invalid blocks forever without a second attempt. We would like to do tracing by default after the second/third execution

kamilchodola commented 3 months ago

@MarekM25 So when we get a newpayload and we will reponose as "Invalid" we should internally keep the request and reexecute it second time to capture traces? Want to understand it,

benaadams commented 3 months ago

@MarekM25 So when we get a newpayload and we will reponose as "Invalid" we should internally keep the request and reexecute it second time to capture traces? Want to understand it,

We already do that; but when we were having block weirdness it passed the second time, so no logs.

So idea was if it passed that second time to accept it as block