NethermindEth / nethermind

A robust execution client for Ethereum node operators.
https://nethermind.io/nethermind-client
GNU General Public License v3.0
1.25k stars 430 forks source link

OnlyStaticPeers should disallow connection from random peers. Move DicoveryEnabled to NetworkConfig. OnlyStaticPeers should implicitly disable Discovery. #5912

Open smartprogrammer93 opened 1 year ago

smartprogrammer93 commented 1 year ago

Description OnlyStaticPeers should disallow connection from random peers. Move DiscoveryEnabled to NetworkConfig. OnlyStaticPeers should implicitly disable Discovery.

Steps to Reproduce In order to replicate the behavior, please provide a detailed list of steps:

  1. Run nethermind with OnlyStaticPeers enabled
  2. Notice how nethermind still connects to non static peers

Actual behavior Connects to non static peers

Expected behavior Should not connect to non static peers

Desktop (please complete the following information): Please provide the following information regarding your setup:

btme0011 commented 1 year ago

Can i work on this issue?

smartprogrammer93 commented 1 year ago

@btme0011 sure

ssonthal commented 2 weeks ago

Hi @smartprogrammer93 is this issue still relevant?

smartprogrammer93 commented 2 weeks ago

@shubham-sonthalia yeah, would you like to work on it?

ssonthal commented 2 weeks ago

yes sure.