search

NethermindEth / nethermind

A robust execution client for Ethereum node operators.
https://nethermind.io/nethermind-client
GNU General Public License v3.0
1.22k stars 427 forks source link

Support for blockOverride in eth_call, eth_estimateGas, eth_createAccessList #6120

Open MarekM25 opened 12 months ago

MarekM25 commented 12 months ago

We need one more parameter: blockOverride to methods eth_call, eth_estimateGas, eth_createAccessList. https://github.com/NethermindEth/nethermind/blob/master/src/Nethermind/Nethermind.JsonRpc/Modules/Eth/EthRpcModule.cs#L337

This parameter should override values specified here: https://github.com/NethermindEth/nethermind/blob/master/src/Nethermind/Nethermind.Facade/BlockchainBridge.cs#L245 It should override parameters no matter if treatBlockHeaderAsParentBlock is true or false.

Geth has already implemented it, but only for eth_call and it could be treated as a reference. List of parameters that could be overridden can be found here: https://github.com/NethermindEth/nethermind/blob/master/src/Nethermind/Nethermind.JsonRpc/Modules/Eth/EthRpcModule.cs#L337

bitcoinbrisbane commented 12 months ago

@MarekM25 I can take a look.

MarekM25 commented 11 months ago

Sure - @bitcoinbrisbane assigned you

bitcoinbrisbane commented 11 months ago

Sure - @bitcoinbrisbane assigned you

On it.

bitcoinbrisbane commented 11 months ago

For my reference: https://github.com/etclabscore/core-geth/blob/ed7fd700435f8796437a32e61c2550573cc7e9e1/ethclient/gethclient/gethclient.go#L289

MarekM25 commented 8 months ago

@bitcoinbrisbane are you working on this issue or can I assign it to someone else?