NethermindEth / nethermind

A robust execution client for Ethereum node operators.
https://nethermind.io/nethermind-client
GNU General Public License v3.0
1.24k stars 429 forks source link

add more unittest to test all the changes accompanying verkle #6698

Open tanishqjasoria opened 7 months ago

tanishqjasoria commented 7 months ago
ebukizy1 commented 5 months ago

please will love to work on this issue assign me and give me the necessary information that will also help will get this done asap

guha-rahul commented 5 months ago

Maybe we can tackle this together @ebukizy1. Looking forward to your answer @tanishqjasoria .

ebukizy1 commented 5 months ago

okay .. that would be nice

tanishqjasoria commented 5 months ago

yes, you can pick this up if you want. there are two main categories for test that we need.

  1. Stateless Gas Changes - you can refer to these https://github.com/NethermindEth/nethermind/tree/feature/verkle/src/Nethermind/Nethermind.Evm.Test/Verkle and then the spec https://eips.ethereum.org/EIPS/eip-4762 and add more tests to cover the changes in gas cost.
  2. Block Producing/Processinf tests - here you can find engine module tests here to understand how to write these tests.

you can also refer to this for the changes related to verkle trees

rishabhRsinghvi commented 3 months ago

@tanishqjasoria If it's not done yet, can I pick it up?

tanishqjasoria commented 3 months ago

@rishabhRsinghvi there are few tests already written - https://github.com/NethermindEth/nethermind/pull/7093 you can still pick up Block Producing/Processing tests if you want.

tanishqjasoria commented 1 month ago

everything you described is already implemented in the client. this issues is only about writing unittests for the changes.