search

NethermindEth / nethermind

A robust execution client for Ethereum node operators.
https://nethermind.io/nethermind-client
GNU General Public License v3.0
1.27k stars 438 forks source link

The Nethermind v1.25.4 PPA package will fail to install if the unzip package is not installed #6764

Closed remyroy closed 7 months ago

remyroy commented 8 months ago

Description The Nethermind v1.25.4 PPA package will fail to install if the unzip package is not installed

Steps to Reproduce In order to replicate the behavior, please provide a detailed list of steps:

  1. Install a clean version of Ubuntu 22.04
  2. Add the Nethermind PPA with sudo add-apt-repository ppa:nethermindeth/nethermind
  3. Install the latest Nethermind package with sudo apt-get update && sudo apt-get install nethermind
  4. Observe the package installation failure

Actual behavior

The following additional packages will be installed:
  libsnappy-dev libsnappy1v5
The following NEW packages will be installed:
  libsnappy-dev libsnappy1v5 nethermind
0 upgraded, 3 newly installed, 0 to remove and 0 not upgraded.
Need to get 50.2 kB of archives.
After this operation, 181 kB of additional disk space will be used.
Get:1 http://ca.archive.ubuntu.com/ubuntu jammy/main amd64 libsnappy1v5 amd64 1.1.8-1build3 [17.5 kB]
Get:2 http://ca.archive.ubuntu.com/ubuntu jammy/main amd64 libsnappy-dev amd64 1.1.8-1build3 [30.2 kB]
Get:3 https://ppa.launchpadcontent.net/nethermindeth/nethermind/ubuntu jammy/main amd64 nethermind amd64 1.25.4 [2,486 B]
Fetched 50.2 kB in 0s (119 kB/s)
Selecting previously unselected package libsnappy1v5:amd64.
(Reading database ... 110358 files and directories currently installed.)
Preparing to unpack .../libsnappy1v5_1.1.8-1build3_amd64.deb ...
Unpacking libsnappy1v5:amd64 (1.1.8-1build3) ...
Selecting previously unselected package libsnappy-dev:amd64.
Preparing to unpack .../libsnappy-dev_1.1.8-1build3_amd64.deb ...
Unpacking libsnappy-dev:amd64 (1.1.8-1build3) ...
Selecting previously unselected package nethermind.
Preparing to unpack .../nethermind_1.25.4_amd64.deb ...
Unpacking nethermind (1.25.4) ...
Setting up libsnappy1v5:amd64 (1.1.8-1build3) ...
Setting up libsnappy-dev:amd64 (1.1.8-1build3) ...
Setting up nethermind (1.25.4) ...
Downloading https://github.com/NethermindEth/nethermind/releases/download/1.25.4/nethermind-1.25.4-20b10b35-linux-x64.zip
######################################################################### 100.0%
nethermind.zip: OK
Extracting archive...
/var/lib/dpkg/info/nethermind.postinst: line 37: unzip: command not found
dpkg: error processing package nethermind (--configure):
 installed nethermind package post-installation script subprocess returned error exit status 127
Processing triggers for libc-bin (2.35-0ubuntu3.6) ...
Errors were encountered while processing:
 nethermind
needrestart is being skipped since dpkg has failed

Expected behavior Installing Nethermind through the PPA should just work.

Screenshots The previous package had unzip as a dependency and it just worked.

$ apt show nethermind -a
Package: nethermind
Version: 1.2520
Status: install ok installed
Priority: optional
Section: shells
Maintainer: Demerzel Solutions Limited <hello@nethermind.io>
Installed-Size: 11.3 kB
Depends: libsnappy-dev, libc6-dev, libc6, unzip, jq, curl, wget
Homepage: https://nethermind.io
Download-Size: unknown
APT-Manual-Installed: yes
APT-Sources: /var/lib/dpkg/status
Description: An Ethereum client built on .NET
 A high-performance, highly configurable Ethereum execution client that offers very fast sync speeds and support for external plugins.

Package: nethermind
Version: 1.25.4
Priority: optional
Section: net
Maintainer: Demerzel Solutions Limited <devops@nethermind.io>
Installed-Size: 12.3 kB
Depends: libsnappy-dev
Download-Size: 2,486 B
APT-Sources: https://ppa.launchpadcontent.net/nethermindeth/nethermind/ubuntu jammy/main amd64 Packages
Description: A robust execution client for Ethereum node operators.
 Nethermind is a high-performance, highly configurable Ethereum execution client built on .NET that runs on Linux, Windows, and macOS and supports Clique, Aura, and Ethash. With breakneck sync speeds and support for external plugins, it provides reliable access to rich on-chain data thanks to a high-performance JSON-RPC interface and node health monitoring with Grafana and Seq.

Additional context Adding back unzip as a required dependency package on the Nethermind PPA package should help solve this issue.

kamilchodola commented 7 months ago

@rubo Any update on that?

rubo commented 7 months ago

@kamilchodola See the PR above