7746 inital changes for confirmation

ssonthal commented 1 week ago

Fixes #7746

Please choose one of the keywords above to refer to the issue this PR solves followed by the issue number (e.g. Fixes #000). If no issue number, remove the line. Also, remove everything marked optional that is not applicable. Remove this note after reading.

Changes

List the changes

Types of changes

What types of changes does your code introduce?

[x] Bugfix (a non-breaking change that fixes an issue)
[ ] New feature (a non-breaking change that adds functionality)
[ ] Breaking change (a change that causes existing functionality not to work as expected)
[ ] Optimization
[ ] Refactoring
[ ] Documentation update
[ ] Build-related changes
[ ] Other: Description

Testing

Requires testing

[ ] Yes
[ ] No

If yes, did you write tests?

[ ] Yes
[ ] No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

[ ] Yes
[ ] No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

[ ] Yes
[ ] No

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

ssonthal commented 6 days ago

Hey @obasekiosa/ @LukaszRozmej , can you confirm if these changes look good for the issue.

LukaszRozmej commented 4 days ago

I am not sure if we should update one path based on another or handle it deeper when resolving the path. @rubo ?

Also you accidentally updated submodule.

ssonthal commented 4 days ago

Yes, i will fix the submodule changes.

ssonthal commented 4 days ago

Creating a new PR for the suggested changes as I wasn't able to undo the submodule changes - https://github.com/NethermindEth/nethermind/pull/7765

NethermindEth / nethermind