Exclude empty proofs; 0x0 for 0 instead of 0x - Githubissues

NethermindEth / nethermind

A robust execution client for Ethereum node operators.

https://nethermind.io/nethermind-client

GNU General Public License v3.0

1.28k stars 445 forks source link

Exclude empty proofs; 0x0 for 0 instead of 0x #7766

Closed flcl42 closed 6 days ago

flcl42 commented 1 week ago

Resolves #7759

Remove the difference in responses of proof API

Changes

Exclude empty proofs for not found from results
No leading zeros for proof value
0 means 0x0 instead of 0x (null/empty array)

Types of changes

What types of changes does your code introduce?

[x] Bugfix (a non-breaking change that fixes an issue)
[ ] New feature (a non-breaking change that adds functionality)
[x] Breaking change (a change that causes existing functionality not to work as expected)
[ ] Optimization
[ ] Refactoring
[ ] Documentation update
[ ] Build-related changes
[ ] Other: Description

Testing

Requires testing

[x] Yes
[ ] No

If yes, did you write tests?

[x] Yes
[ ] No

flcl42 commented 6 days ago

7759 @flcl42 qq: does it fix this issue or it is something different?

Yep, seems like that. We are getting empty storage proof values and want not to return em anymore