NethermindEth / rpc-request-builder

https://rpc-request-builder.voyager.online/
5 stars 16 forks source link

Implements starknet.go Class RPC endpoints for builder #27

Closed dhirajs0 closed 6 months ago

dhirajs0 commented 6 months ago

support for starknet.go code for the following RPC endpoints

starknet_getClass starknet_getClassHashAt starknet_getClassAt

Closes #9

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rpc-request-builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 4:21am
dhirajs0 commented 6 months ago

Please make the changes and resolve the conflicts and it should be GTM.

Made the suggested changes.

jelilat commented 6 months ago

Thank you for your contribution @dhirajs0

AryanGodara commented 6 months ago

@jelilat I had a doubt in these implementations. Since this is an RPC builder, and the requests are editable.

image

Initially, the code is correct, according to the fields like latest or blockHash.

But, as soon as I edit any input field, the code restructures, and is no longer correct. So, the configuration of the request isn't really working. I noticed this in most examples other than javascript, ie for Go and Rust Eg.:

image

After changing classHash, the hextoFelt line disappears

image

after changing block number, the input parameter changes completely.

jelilat commented 6 months ago

@AryanGodara This happens because the only acceptable block tag is "latest" or "pending". If you edit the block tag to pending, it should be properly updated.

For example, this is what it looks like if I change the tag to "pending"

Screenshot 2024-03-06 at 15 04 09
AryanGodara commented 6 months ago

@AryanGodara This happens because the only acceptable block tag is "latest" or "pending". If you edit the block tag to pending, it should be properly updated.

For example, this is what it looks like if I change the tag to "pending"

Screenshot 2024-03-06 at 15 04 09

Oh cool! I was initially confused about this, thanks for clearing it up @jelilat :D