search

NethermindEth / rpc-request-builder

https://rpc-request-builder.voyager.online/
5 stars 16 forks source link

Add missing starknet.js code #3

Open jelilat opened 8 months ago

jelilat commented 8 months ago

The following endpoints have missing starknet.js code

makluganteng commented 7 months ago

Hi may i take this issue ?

AryanGodara commented 7 months ago

The following endpoints have missing starknet.js code

  • starknet_call
  • starknet_estimateFee
  • starknet_estimateMessageFee
  • starknet_addInvokeTransaction
  • starknet_addDeclareTransaction
  • starknet_addDeployAccountTransaction
  • starknet_simulateTransactions

Can you please go tell how to get started with this task; I have good experience writing APIs, but some more context would be really helpful to get started :D

Blazing-Mike commented 6 months ago

@makluganteng is it possible i take some of the methods. or you are done solving them. there are no js issues to solve.

makluganteng commented 6 months ago

Im all good no worries 🙏

Blazing-Mike commented 6 months ago

Alright.

makluganteng commented 6 months ago

HI i have a question on the estimate fee , there are multiple type of transaction do i put into the same inside the starknet.js 


// Estimate the fee for StarkNet transactions
  {
    name: "starknet_estimateFee",
    params: {
      request: [BROADCASTED_INVOKE_TXN], //TODO:
      simulation_flags: [
        {
          placeholder: "SKIP_VALIDATE",
          description:
            "Flags that indicate how to simulate a given transaction. By default, the sequencer behavior is replicated locally",
        },
      ],
      block_id,
    },
    starknetJs: `${STARKNET_JS_PREFIX} //here but im wondering how to differentiate the transaction here
    `,
    starknetGo: ``,
    starknetRs: ``,
  },```
jelilat commented 6 months ago

HI i have a question on the estimate fee , there are multiple type of transaction do i put into the same inside the starknet.js

// Estimate the fee for StarkNet transactions
  {
    name: "starknet_estimateFee",
    params: {
      request: [BROADCASTED_INVOKE_TXN], //TODO:
      simulation_flags: [
        {
          placeholder: "SKIP_VALIDATE",
          description:
            "Flags that indicate how to simulate a given transaction. By default, the sequencer behavior is replicated locally",
        },
      ],
      block_id,
    },
    starknetJs: `${STARKNET_JS_PREFIX} //here but im wondering how to differentiate the transaction here
    `,
    starknetGo: ``,
    starknetRs: ``,
  },```

@makluganteng Not sure I fully understand your question. Can you please rephrase?

makluganteng commented 6 months ago

Sorry , so i saw there was multiple type of transaction and do we add that types of transaction on the code above ? or we need to make extra validation on the FE if its this type of transaction then there should be different code