search

NethermindEth / sedge

A one-click setup tool for PoS network/chain validators and nodes.
https://docs.sedge.nethermind.io
Apache License 2.0
157 stars 46 forks source link

Nethermind 1.21.0 broke sedge #330

Closed Khepesh closed 12 months ago

Khepesh commented 1 year ago

Describe the bug Can't upgrade to Nethermind 1.21.0 and will not be able to in future releases.

To Reproduce Upgrade Nethermind in 1.21.x

stdevMac commented 1 year ago

Hello @Khepesh ! Thanks for reaching us, can you share more logs of what is happening? provide more details in general of the error you are getting? Thanks in advance!

Khepesh commented 1 year ago

I'm no expert but to make it short I got a "DNS issue" error and the validator never start, I thought it would be a known issue related to 1.21.0's update breaking change:

⚠️ IMPORTANT

The Nethermind executable has been renamed from Nethermind.Runner to nethermind The Nethermind Launcher executable has been renamed from Nethermind.Launcher to nethermind-launcher The Nethermind CLI executable has been renamed from Nethermind.Cli to nethermind-cli The Docker images entry points have been updated accordingly. Please update your setups accordingly, if any.

stdevMac commented 1 year ago

Can you please show the outputs of sedge logs execution?

stdevMac commented 1 year ago

In any case we are working on a release with the latest nethermind version available soon, so should solve your issue 🙏

Khepesh commented 1 year ago

got no issue actually coz i went back to 1.20.4 but here is what i got with 1.21.1 :

image

stdevMac commented 1 year ago

@Khepesh which version of sedge you are using? We fixed that problem in current latest version of sedge

Khepesh commented 1 year ago

latest One, 1.2.3

cbermudez97 commented 1 year ago

Hi @Khepesh looks like the Nethermind configuration that is being used by Sedge is using --config=xdai instead of --config=gnosis. This is a expected issue since xdai config is now renamed to gnosis in Nethermind client.

To update you can go inside the sedge-data directory and modify the docker-compose.yml. Inside find the execution service and change the xdai config to gnosis.

Please let us know if this change allow you to upgrade to Nethermind 1.21 👍

Khepesh commented 1 year ago

Hi, It looks like it's working, but it's doing a full sync (it changed the db folder name from xdai to gnosis, didn't take the "risk" to just rename it) Still at ~33% so there are still some hours left to confirm it's working perfectly.

just to add a comment, the modification i had to do wasn't in the docker-compose file but in the .env : Docker-compose.yml : image .env : image

Khepesh commented 12 months ago

well it indeed resolved the issue. Just a word but 1.22.0 is working fine too.