NethermindEth / sedge

A one-click setup tool for PoS network/chain validators and nodes.
https://docs.sedge.nethermind.io
Apache License 2.0
155 stars 46 forks source link

Integrate EL monitoring stack #406

Closed khalifaa55 closed 1 month ago

khalifaa55 commented 1 month ago

Changes:

What types of changes does your code introduce? Put an x in the boxes that apply

Testing

Requires testing

In case you checked yes, did you write tests?

khalifaa55 commented 1 month ago

Main Changes

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 92.06030% with 79 lines in your changes missing coverage. Please review.

Project coverage is 88.06%. Comparing base (ea6586f) to head (178116a).

Files with missing lines Patch % Lines
internal/pkg/services/docker.go 89.71% 21 Missing and 8 partials :warning:
internal/compose/compose.go 78.68% 13 Missing :warning:
...ernal/monitoring/services/node_exporter/service.go 55.55% 10 Missing and 2 partials :warning:
internal/monitoring/services/grafana/service.go 89.04% 6 Missing and 2 partials :warning:
internal/monitoring/services/prometheus/service.go 93.57% 4 Missing and 3 partials :warning:
internal/monitoring/monitoring.go 97.29% 2 Missing and 2 partials :warning:
cli/monitoring.go 95.83% 1 Missing and 1 partial :warning:
internal/monitoring/data/datadir.go 93.93% 2 Missing :warning:
internal/monitoring/services/types/types.go 50.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #406 +/- ## =========================================== + Coverage 87.47% 88.06% +0.59% =========================================== Files 92 99 +7 Lines 4774 5673 +899 =========================================== + Hits 4176 4996 +820 - Misses 492 553 +61 - Partials 106 124 +18 ``` | [Flag](https://app.codecov.io/gh/NethermindEth/sedge/pull/406/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NethermindEth) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/NethermindEth/sedge/pull/406/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NethermindEth) | `88.06% <92.06%> (+0.59%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NethermindEth#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.