Closed khalifaa55 closed 1 month ago
Merged dockerManager interface from EL repo with serviceManager interface from Sedge into dockerServiceManager.
Adjust code for composeManager from EL to use code from CommandRunner implementation. composeManager in EL.
Include monitoring
package in internal/monitoring which has all packages needed by the monitoringStack
from EL .
Generate mocks needed by the new packages in internal/monitoring into sedge_mocks
package, except for internal/monitoring/locker/lock.go mocks are generated in internal/monitoring/locker/mocks (to prevent import cycles).
Adjust file handling in test cases (in monitoring
package) using PathMatcher to work with Windows as well as Linux OS.
Remove unneeded code from internal/monitoring/data package (package in EL repo)
Skip e2e tests in unit-tests workflow in CI/CD pipeline (updated Makefile and unit-tests.yml)
Attention: Patch coverage is 92.06030%
with 79 lines
in your changes missing coverage. Please review.
Project coverage is 88.06%. Comparing base (
ea6586f
) to head (178116a
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Changes:
Types of changes
What types of changes does your code introduce? Put an
x
in the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?