Closed AntiD2ta closed 1 hour ago
Attention: Patch coverage is 17.64706%
with 252 lines
in your changes missing coverage. Please review.
Project coverage is 44.34%. Comparing base (
000cc79
) to head (2ecb064
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We should add documentation either on this PR or in other, about this new app
Changes:
Types of changes
What types of changes does your code introduce? Put an
x
in the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?
Further comments (optional)
Since there are two apps in the repo now, we have to create a PR after merging this to move app-specific packages to the app folder (the lido-exporter app has its own
cli
folder for example). Thee2e
folder is respecting this new structure and there is a suite implementation for each app (sedge and lido-exporter).406 updates sedge's e2e test suite and test cases. The CI will likely fail for this PR since some critical changes and fixes are in #406.