NethermindEth / sedge

A one-click setup tool for PoS network/chain validators and nodes.
https://docs.sedge.nethermind.io
Apache License 2.0
150 stars 42 forks source link

Add Lido-Exporter app #411

Closed AntiD2ta closed 1 hour ago

AntiD2ta commented 6 days ago

Changes:

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

Testing

Requires testing

In case you checked yes, did you write tests?

Further comments (optional)

Since there are two apps in the repo now, we have to create a PR after merging this to move app-specific packages to the app folder (the lido-exporter app has its own cli folder for example). The e2e folder is respecting this new structure and there is a suite implementation for each app (sedge and lido-exporter).

406 updates sedge's e2e test suite and test cases. The CI will likely fail for this PR since some critical changes and fixes are in #406.

codecov-commenter commented 2 days ago

Codecov Report

Attention: Patch coverage is 17.64706% with 252 lines in your changes missing coverage. Please review.

Project coverage is 44.34%. Comparing base (000cc79) to head (2ecb064).

Files with missing lines Patch % Lines
cmd/lido-exporter/cli/lido_exporter.go 0.00% 92 Missing :warning:
cmd/lido-exporter/metrics/metrics.go 0.00% 41 Missing :warning:
cmd/lido-exporter/metrics/penalties.go 0.00% 31 Missing :warning:
cmd/lido-exporter/metrics/exit_requests.go 0.00% 18 Missing :warning:
cmd/lido-exporter/metrics/keys.go 0.00% 16 Missing :warning:
cmd/lido-exporter/metrics/bonds.go 0.00% 15 Missing :warning:
cmd/lido-exporter/metrics/node_operator.go 0.00% 14 Missing :warning:
cmd/lido-exporter/metrics/rewards.go 0.00% 12 Missing :warning:
cmd/lido-exporter/main.go 0.00% 6 Missing :warning:
configs/networks.go 58.33% 5 Missing :warning:
... and 1 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #411 +/- ## ============================================ - Coverage 88.06% 44.34% -43.73% ============================================ Files 99 114 +15 Lines 5673 9797 +4124 ============================================ - Hits 4996 4344 -652 - Misses 553 4991 +4438 - Partials 124 462 +338 ``` | [Flag](https://app.codecov.io/gh/NethermindEth/sedge/pull/411/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NethermindEth) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/NethermindEth/sedge/pull/411/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NethermindEth) | `44.34% <17.64%> (-43.73%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NethermindEth#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stdevMac commented 1 hour ago

We should add documentation either on this PR or in other, about this new app