NethermindEth / starknet-contract-verifier

CLI to verify your starknet contracts classes on block explorers!
Apache License 2.0
19 stars 10 forks source link

Add verbose error msgs in CLI verifier #35

Closed Bart-Do closed 3 months ago

Bart-Do commented 5 months ago

There is not always a clear error message when the CLI verification process fails. We should provide verbose error messaging at least for the main cases the process can fail.

Analyse the flow and the cases where the verifier might fails and include applicable error messages.

amanusk commented 4 months ago

It would be great to have a notification that a class is not found right after the class hash is supplied. Currently class hash is supplied as a second parameter, then the process continues, only to find out that the class was not found.

If this information can be obtained right after the class is submitted, there is no point in continuing the process.

Example:

✔ Which network would you like to verify on :  · Sepolia
✔ Input class hash to verify :  · 0x062d131db7c7522e7a4347707423e218a95c8445c21a183a804b41fa4ed0899f
✔ Enter Class Contract Path : · .
✔ Select license you'd like to verify under : · NoLicense
✔ Enter your desired class name:  · HelloStarknet
Is this an Account Class? no
Error: Class does not exist on the network
liam-nethermind commented 3 months ago

@Bart-Do Can we close this as completed?