search

NethermindEth / starknet-contract-verifier

CLI to verify your starknet contracts classes on block explorers!
19 stars 7 forks source link

fix: resolve path error and improve versioning error #57

Closed liam-nethermind closed 2 months ago

liam-nethermind commented 2 months ago

Closes #23, #59

cwkang1998 commented 2 months ago

Hey, is there a ticket for this already opened? If not can you either open a ticket for this on github or if the ticket only exists on our taskboard on notion can you point me to it so I can copy / move it here?

liam-nethermind commented 2 months ago

Hey, is there a ticket for this already opened? If not can you either open a ticket for this on github or if the ticket only exists on our taskboard on notion can you point me to it so I can copy / move it here?

resolve path error - #42 improve versioning error - #59 or #23 (not sure it's the same case)

cwkang1998 commented 2 months ago

@liam-nethermind seems that your commits are unverified, is it possible to resign them? Minor issues, but will be great.

liam-nethermind commented 2 months ago

@cwkang1998 Fixed. Can you review it again?