search

NethermindEth / starknet.go

Golang Library for StarkNet/Cairo
MIT License
143 stars 95 forks source link

Update account tests to sepolia #558

Closed AryanGodara closed 1 month ago

AryanGodara commented 2 months ago

Partially resolves #544

rianhughes commented 2 months ago

Just two general points:

  1. You need to replace the test data that was gathered from the Goerli network, with new test data from the Sepolia network. This will go for the other PRs as well.

  2. I would suggest running the tests in the account package against a Sepolia network endpoint, ie running "go test ./... -env testnet -v" from the accounts pacakge. You will probably need to put a .env.tesnet file in the account package, with a URL of a Seploia full node. https://data.voyager.online/

AryanGodara commented 2 months ago

Just two general points:

  1. You need to replace the test data that was gathered from the Goerli network, with new test data from the Sepolia network. This will go for the other PRs as well.
  2. I would suggest running the tests in the account package against a Sepolia network endpoint, ie running "go test ./... -env testnet -v" from the accounts pacakge. You will probably need to put a .env.tesnet file in the account package, with a URL of a Seploia full node. https://data.voyager.online/

I used existing transactions which were similar to the goerli ones. So these were real transactions I found on the block-explorer. But some of them don't seem to exist anymore. (I'd picked the most recent ones that matched) For the other tests also, I've used real sepolia data.

But you're right. I need to create new transactions here, with a test wallet. I'll get to this asap!