search

NethermindEth / starknet.go

Golang Library for StarkNet/Cairo
MIT License
142 stars 95 forks source link

Consider to use stretchr instead of test-go #581

Closed mdantonio closed 6 days ago

mdantonio commented 6 days ago

I noticed that you are using test-go/testify for test assertions (link to go.mod). This project is a pretty old fork of stretchr/testify and it looks to be no longer maintened (last commit is 7 years ago). Curious to know if the fork includes some feature not available on the mainstream, otherwise I think you could consider to migrate to stretchr, that should only require to change the import paths, if no specific functionalities from test-go are currently used)

Also note that on contracts_test it is mentioned that tests are based on stretchr (ref and ref)

thiagodeev commented 6 days ago

Hi @mdantonio, thanks for pointing this out. It's a valid observation. Since the fork is working without any issues, this is not a priority at the moment. Could you open a PR about this? It would be welcome

mdantonio commented 6 days ago

Sure, here you are @thiagodeev https://github.com/NethermindEth/starknet.go/pull/582

thiagodeev commented 6 days ago

Done by @mdantonio at https://github.com/NethermindEth/starknet.go/pull/582. Thanks again

mdantonio commented 6 days ago

Nice, thank you!