search

NethermindEth / starknet.go

Golang Library for StarkNet/Cairo
MIT License
143 stars 95 forks source link

Adding support for Byte array serialization #583

Open krishnateja262 opened 1 week ago

krishnateja262 commented 1 week ago

Utility function which takes in a string and converts it to array of felt objects

krishnateja262 commented 1 week ago

@thiagodeev Please check and let me know if any changes are required

thiagodeev commented 6 days ago

Nice code @krishnateja262! I'll make some comments

thiagodeev commented 3 days ago

Very good @krishnateja262! Now we just need to make some adjustments to the test function

krishnateja262 commented 3 days ago

Very good @krishnateja262! Now we just need to make some adjustments to the test function

Hi @thiagodeev the last 2 test cases have exactly 31 and 62 characters respectively with required output felt array having 0x0 as the ending value. These tests are passing. Are there any other changes you are looking for?

thiagodeev commented 2 days ago

One last thing: have you tested this function interacting with a Cairo method that requires a ByteArray as input? Did it work?