search

NethermindEth / starknet.go

Golang Library for StarkNet/Cairo
MIT License
143 stars 95 forks source link

chore ::> Merging all TransactionReceipt types into a single type #588

Open PsychoPunkSage opened 3 days ago

PsychoPunkSage commented 3 days ago

Closes #576

Here I created a superset type that can accommodate all the fields required by the different transaction receipts. This include includes all the fields from the various receipt types. Then I update the unmarshalling logic to populate this new superset type based on the fields present in the JSON data.

PsychoPunkSage commented 3 days ago

hi @rianhughes I tried to formulate a way to solve #567 Can you please give some suggestion on the approach before I start working on its proper integration with rest of the repo? My method is in a temporary file called rpc/types_transaction_receipt_pps.go.... I will later on put the logic inside rpc/types_transaction_receipt.go once the approach is finalized.

PsychoPunkSage commented 1 day ago

@rianhughes Integrated everything with a common TransactionReceipt. All test are passing. Please have a look whenever you are free.