search

NethermindEth / warp

Warp - Bringing Solidity to Starknet at warp speed. Warp is a Solidity to Cairo Compiler, this allows teams to write/migrate Solidity to Cairo for easy onboarding into the StarkNet ecosystem.
https://nethermind.io/warp/
Apache License 2.0
754 stars 70 forks source link

Update warp memory functionality to Cairo 1 #1045

Closed rodrigo-pino closed 1 year ago

piwonskp commented 1 year ago

Is there any behaviour test we could uncomment?

rodrigo-pino commented 1 year ago

Is there any behaviour test we could uncomment?

I wouldn't do it just yet. During memory development we found a bunch of small errors scattered everywhere we are currently solving. I think we should start testing behaviour with non memory/storage/calldata stuff first if possible, to also discard possible errors on the testnet side

piwonskp commented 1 year ago

Is there any behaviour test we could uncomment?

I wouldn't do it just yet. During memory development we found a bunch of small errors scattered everywhere we are currently solving. I think we should start testing behaviour with non memory/storage/calldata stuff first if possible, to also discard possible errors on the testnet side

We are already running behaviour tests that are non memory/storage/calldata

temyurchenko commented 1 year ago

https://github.com/NethermindEth/warp/pull/1045#discussion_r1208123402

I've made a search for functions that start with "try_" in the Cairo codebase and in all cases it's functions that might return a failure (Option), but not panic. Since this function may panic, it might probably make sense to prefix it with "unsafe".

cc @piwonskp @rodrigo-pino

(for some reason, I can't reply in the thread itself)