search

NethermindEth / warp

Warp - Bringing Solidity to Starknet at warp speed. Warp is a Solidity to Cairo Compiler, this allows teams to write/migrate Solidity to Cairo for easy onboarding into the StarkNet ecosystem.
https://nethermind.io/warp/
Apache License 2.0
754 stars 70 forks source link

Cairo1 bump up to v1.0.0-rc0 #1051

Closed AlejandroLabourdette closed 1 year ago

piwonskp commented 1 year ago

The PR requires https://github.com/0xSpaceShard/starknet-devnet/pull/472 and an update to dependencies before it gets merged

piwonskp commented 1 year ago

It's merged now, let's update dependencies for starknet devnet

rodrigo-pino commented 1 year ago

I've added the new Warp binary for 1.0.0-rc for arm. Also updated warplib code to be compatible with new version. As soon as someone updates for x86_64, test should start passing

piwonskp commented 1 year ago

Everything looks in order to me, however I want to learn more about the approaches taken.

Why do we keep two versions of the corelib for different architectures? What is the difference? Have we considered the alternative of having a submodule pointing to a particular tag in the StarkWare repository? Are we set on keeping the binaries in the repo long-term?

We plan to use normal package management long-term, either cairo-lang from pip or cairo compiler from cargo. Probably it will be cargo long term

piwonskp commented 1 year ago

I've made an issue for that https://github.com/NethermindEth/warp/issues/1068

temyurchenko commented 1 year ago

I've made an issue for that #1068

I see, thank you. Is that also the reason that we duplicate the library? No reason not too, given that this is temporary anyway?

piwonskp commented 1 year ago

Exactly, I guess it was easier that way

temyurchenko commented 1 year ago

Exactly, I guess it was easier that way

I see the point, but just as a note one symlink would serve well to lessen the code/changes blowup