search

NethermindEth / warp

Warp - Bringing Solidity to Starknet at warp speed. Warp is a Solidity to Cairo Compiler, this allows teams to write/migrate Solidity to Cairo for easy onboarding into the StarkNet ecosystem.
https://nethermind.io/warp/
Apache License 2.0
754 stars 70 forks source link

Get rid of `felt_into_bool` and `bool_into_felt` #1067

Open piwonskp opened 1 year ago

piwonskp commented 1 year ago

Serialization code should be refactored to use generic functions within https://github.com/NethermindEth/warp/blob/cairo-1.0/warplib/src/warp_memory/accessors.cairo#L95 instead of using conversion functions and then writing to the memory.

After refactoring felt_into_bool and bool_into_felt (https://github.com/NethermindEth/warp/blob/cairo-1.0/warplib/src/conversions/integer_conversions.cairo#LL20C40-L20C40) should be removed