NethermindEth / zksync-remix-plugin

Remix plugin for zkSync
MIT License
13 stars 11 forks source link

Refactor the compilation UX to distinguish between "single file compilation" and "project compilation" #128

Closed stranger80 closed 2 months ago

stranger80 commented 3 months ago

Refactor the Compile feature to follow the requirements mentioned below:

satyambnsal commented 3 months ago

127 Addresses all the listed items in the issue description except:

If we have multiple contracts wit the same name, those "duplicating" names will be
labelled with additional info (ContractName (<file_name>)) in the item
(Priority 2) ...and tooltip showing full path (<path>/<file_name>)

Upon closer examination of the codebase, it appears this feature should be implemented as a separate issue. It requires careful state modifications that are closely tied to the deploy contract functionality. For the sake of avoiding unintended side effects, it's recommended to handle this as a distinct task.

PatrickAlphaC commented 3 months ago

Looking forward to this update. Seems a lot of people are still having friction with the warning.

We have added updates on our side as well.

satyambnsal commented 2 months ago

Fixed as part of 0.4.2 release.

Now there are two Compile options in the plugin:

  1. Compile Project: Follows hardhat directory structure and compiles all contracts present in contracts directory.
  2. Single file compilation: Select a solidity file from workspace and compile it by clicking Compile <file-name> button.
PatrickAlphaC commented 2 months ago

Very helpful!