Nethravathitcs / unitt

Automatically exported from code.google.com/p/unitt
0 stars 0 forks source link

WebSocket10 reports Sec-WebSocket-Version 10, but actually should be 8 #39

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
According to the Hybi spec for version 10, the handshake should report version 
8 instead (oddly enough).

from 
http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-10#section-5.1

   9.   The request MUST include a header with the name "Sec-WebSocket-
        Version".  The value of this header MUST be 8. _Note: Although a
        draft -09 was published, as -09 was comprised of editorial
        changes and not changes to the wire protocol, 9 was not used as
        a valid value for Sec-WebSocket-Version.  This value was
        reserved in the IANA registry but was not and will not be used.
        If subsequent changes to the wire protocol are necessary, 9 will
        be skipped to prevent confusion with the draft 9 protocol._

This allows Unitt's Hybi-10 to correct connect to Tornado. It would not 
otherwise.

Original issue reported on code.google.com by aa...@azinman.com on 13 Jan 2012 at 11:44

GoogleCodeExporter commented 8 years ago
Good catch. I thought a later version specified you were supposed to use 10, 
but I guess not. 

Original comment by joshuadmorris@gmail.com on 18 Jan 2012 at 6:58

GoogleCodeExporter commented 8 years ago

Original comment by joshuadmorris@gmail.com on 30 Jan 2012 at 6:39

GoogleCodeExporter commented 8 years ago
This is now fixed in trunk. After a validation pass I will generate a new build.

Original comment by joshuadmorris@gmail.com on 30 Jan 2012 at 6:44

GoogleCodeExporter commented 8 years ago

Original comment by joshuadmorris@gmail.com on 31 Jan 2012 at 6:32