search

NetroScript / backpack.tf-miscellaneous-extensions

This is an userscript to add miscellaneous functionality to backpack.tf.
Apache License 2.0
12 stars 6 forks source link

Integrated Killstreak Kit Additions to the script #8

Closed HairGMan closed 2 years ago

HairGMan commented 2 years ago

I made this small script earlier this year that adds some shortcuts to different killstreak tiers, along with kits/fabricators, to the stats pages of all weapons, kits and fabs. I uploaded it to its own repo last week, then got contacted by Moder112, who lent me a hand with optimizing the code and recommended I make it a part of Misc Extensions, so I did just that! I'm opening this pull request to see if you'd like to add my code to your script. Here's my script's standalone repo: https://github.com/HairGMan/bptf-killstreak-kit-additions If you have any questions about the code or you'd want me to change anything, please feel free to tell me! Thanks for your time!

NetroScript commented 2 years ago

Ah and one more thing I forgot to mention is, that you also should increment the version of the script to 0.1.26 (don't forget the header too) and also add the changes to the changelog in the README. Since 0.1.25 your functionality has been added (after merging this) and additionally:

Fixed:

* Incorrect classifieds queries on paintkit items

which was the previous commit by @Moder112

HairGMan commented 2 years ago

Thank you so much for the review! I already commited all the changes you suggested. This is the first userscript I've ever written, so all the corrections, even the small things, are appreciated, and I'll keep them in mind for the future! If you need anything else changed before merging, hit me up and I'll add it.

NetroScript commented 2 years ago

Thank you again for your time and the PR!