search

NetroScript / backpack.tf-miscellaneous-extensions

This is an userscript to add miscellaneous functionality to backpack.tf.
Apache License 2.0
12 stars 6 forks source link

Group by Killstreak or Original Id and Fix spell groupings #9

Closed joekiller closed 2 years ago

joekiller commented 2 years ago

Add group by killstreak kit. Add group by original id.

BP.tf seems to be marking footprints as footsteps now.

NetroScript commented 2 years ago

Thank you for this PR!

It adds some really nice features and I don't even have anything to nag about besides one thing:

I personally think it would be better, if the different types of Killstreaker have a solid color, instead of two colors, maybe even the same for all.

This is because you can't really assign Fire Horns, Tornado or Singularity a color, rather the sheens cause this color. So I especially would not use any colors, which can be related to the sheens. For example Cerebral Discharge is team colored, so one might think there is a connection to Team Shine too.

But if you think otherwise, I am also open to discuss that.

joekiller commented 2 years ago

Your points are valid! I had the same thought but then forgot to go back and work on the colors. I'll get a better variation in there. Thanks for the constructive feedback!

joekiller commented 2 years ago

I have updated the highlight to be a color pick from the pro ks image. It's kind of a rusty orange. Different enough from the sheens, esp like mandarin.