search

NetrunnerMopus / data-hunt

Netrunner for the masses
The Unlicense
12 stars 4 forks source link

% Inverted the "on" and "off" behaviour, using the grey color to indi… #1997

Closed JeffSkyrunner closed 4 years ago

JeffSkyrunner commented 4 years ago

…cate the card deactivation

JeffSkyrunner commented 4 years ago

This is linked to this issue

dagguh commented 4 years ago

image Hmm, it leads to an interesting effect. Only the Sure Gamble is dimmed (slightly). So as a newcomer to the UI, I see the stolen agenda, the installed Mongoose, my id, enemy cards and enemy credits or my clicks. And I don't know that I can use some of them and some are not meant to be interactive. Dimming inactive elements would mean dimming almost all of them, most of the screen. The initial idea behind #25 was to make the highlights stand out more. Perhaps some particle effects, glow, subtle animation (micro-shaking?). Make it feel more alive and vibrant. What do you think?

JeffSkyrunner commented 4 years ago

Uhm... I see your point and definitely agree that would be better from newcomers' point of view.

In my opinion we have two way to approach this:

  1. Accept this merge from an "agile" point of view: we can consider this as an improvement of the actual UI and ship this while adding a new issue to improve the behavior as you correctly suggested;
  2. Reject this and wait for the proper improvement you suggested
dagguh commented 4 years ago

I'm in favor of merging even slight improvements, but I'm afraid that this one is a small regression. Beforehand, all playable elements were consistently highlighted. Now, some of playable elements are not dimmed. Would you agree to revisit this with a different approach later on?

JeffSkyrunner commented 4 years ago

I would, but I don't know when I would be able to do so, since my current hardware situation :)

So I would suggest to reject the pull request and unassign the issue, in case someone would be able to pick this up.

On Mon, Jun 29, 2020 at 4:52 PM Maciej Kwidziński notifications@github.com wrote:

I'm in favor of merging even slight improvements, but I'm afraid that this one is a small regression. Beforehand, all playable elements were consistently highlighted. Now, some of playable elements are not dimmed. Would you agree to revisit this with a different approach later on?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dagguh/data-hunt/pull/1997#issuecomment-651207224, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4ZCQQOBMJZFGOKJRUESALRZC2CJANCNFSM4OJPUWGQ .