Nets-mobile-acceptance / Netaxept-Android-SDK

PiA Netaxept Android SDK is a library that provides the native In-App interaction to perform Netaxept payments directly from an app on Android devices while minimizing PCI DSS requirements for you.
31 stars 15 forks source link

SDK 2.5.0 contains 2x android.permission.VIBRATE elements #48

Closed khltrifork closed 2 years ago

khltrifork commented 3 years ago

Snippet of SDK 2.4.0 manifest:

<!-- section-start-to-remove-by-script -->
<!-- permissions required by card scanner -->
<uses-permission android:name="android.permission.CAMERA" />
<uses-permission android:name="android.permission.VIBRATE" />

<uses-feature
    android:name="android.hardware.camera"
    android:required="false" />
<uses-feature
    android:name="android.hardware.camera.autofocus"
    android:required="false" />

<!-- end -->
<!-- section-end-to-remove-by-script -->
<application
    android:allowBackup="true"
    android:supportsRtl="true" >

Snippet of SDK 2.5.0 manifest:

<!-- section-start-to-remove-by-script -->
<!-- permissions required by card scanner -->
<uses-permission android:name="android.permission.CAMERA" />
<uses-permission android:name="android.permission.VIBRATE" />

<uses-feature
    android:name="android.hardware.camera"
    android:required="false" />
<uses-feature
    android:name="android.hardware.camera.autofocus"
    android:required="false" />
<!-- end -->
<!-- section-end-to-remove-by-script -->

<uses-permission android:name="android.permission.VIBRATE" />

<application
        android:allowBackup="true"
        android:supportsRtl="true" >

This line is duplicated twice in the SDK 2.5.0 manifest:

<uses-permission android:name="android.permission.VIBRATE" />

This causes build warnings:

[eu.nets.pia:pia-sdk:2.5.0] /Users/xyz/.gradle/caches/transforms-3/702d7def17f8bb617cd6d663a51c283c/transformed/jetified-pia-sdk-2.5.0/AndroidManifest.xml:35:5-66 Warning: Element uses-permission#android.permission.VIBRATE at [eu.nets.pia:pia-sdk:2.5.0] AndroidManifest.xml:35:5-66 duplicated with element declared at [eu.nets.pia:pia-sdk:2.5.0] AndroidManifest.xml:24:5-66

Miss-PiA commented 3 years ago

Hi,

Thank you for your inpuits, we have rectified this issue in our latest release of version 2.5.1

Please try out the latest version and reach out if you find any issues that needs out attention.

BR

khltrifork commented 2 years ago

This is now again an issue in 2.6.0.

BuildManager-Nets commented 2 years ago

Hi,

Thank you for your quick inpuits, we will be releasing a 2.6.1 version with this fix.

The estimation for this release is tommorow.

BR

BuildManager-Nets commented 2 years ago

Hi,

Thank you for your inputs, we have rectified this issue in our latest release of version 2.6.1

Please try out the latest version and reach out if you find any issues that needs out attention.

BR