search

Nettakrim / Signed-Paintings

14 stars 3 forks source link

Images appear darkened #17

Open JustAlittleWolf opened 8 months ago

JustAlittleWolf commented 8 months ago

Images are displayed a lot darker in comparison to the image source

Minecraft image (with fullbright enabled): image

Source image: image

This happens for all images, not just specific ones.

This is a minor inconvenience, but it would be nice if it'd be fixed.

JustAlittleWolf commented 8 months ago

For me changing the normal Vector here: https://github.com/Nettakrim/Signed-Paintings/blob/e4f5e4afa79d38be06c4a6e33417910bbc565aa3/src/main/java/com/nettakrim/signed_paintings/rendering/Cuboid.java#L81

to

new Vector3f(0, 1, 0)

did the job, but that didn't work for my friend.

Nettakrim commented 8 months ago

interesting, i have a pretty long list of increasingly critical things to fix so ill be going through all the issues soon, makes sense there might be normal shenanigans

Nettakrim commented 8 months ago

image ah the reason is because im using the same lighting that the signs themselves do - im not sure if this behaviour is desirable

BondarenkoArtur commented 5 months ago

I would say it's not a bug, it's a feature :grinning:

It allows to make blinking / bright pictures as ads with simple redstone lamp

https://github.com/Nettakrim/Signed-Paintings/assets/9720950/93a15eb1-d1b9-40b8-9441-ec2fb1910fb8

JustAlittleWolf commented 5 months ago

@BondarenkoArtur well the lighting on signs is desired, but even at maximum light Level 15 they don't match the actual brightness of the same image when viewed in another program, in the browser for example.

BondarenkoArtur commented 5 months ago

Yes, I see, tried your suggestion, works for me, colors are better. But I'm personaly not clear how that works. image top image with same light level, bottom with high light level and offset.

Nettakrim commented 5 months ago

im pretty sure its because minecraft shades faces based on their angle, not because of block light level - block light does contribute, but even when in light level 15 an image may be darker based on its angle, which is what this issue is referring to

BondarenkoArtur commented 5 months ago

I was trying to put sign from all 4 sides of glowstone block, result seems dull for each of that :thinking:

Nettakrim commented 5 months ago

this is working as intended. insofar as it is currently consistent with minecraft

im pretty sure its nothing to do with light level, its because minecraft shades north/south faces lighter than east/west ones, and top faces are brighter still

you can easily see this with the new rotation sliders, or by just looking at some terrain java_CgaVXmzRBv