search

Netuitive / chef-netuitive

Installs Native Netuitive Agent
MIT License
4 stars 6 forks source link

Update docs #20

Closed jkauffman503 closed 8 years ago

jkauffman503 commented 8 years ago

Updating both ReadMe and Contributing to have consistent formatting

jkauffman503 commented 8 years ago

@shawnbutts @majormoses @Createor I wanted to take a hack at updating the Contributing.md and README.md files to be consistent with our our other GitHub projects. Please let me know if you have any feedback, or if you liked some things they way they used to be.

majormoses commented 8 years ago

@jkauffman503 I think there are definitely some good changes here though I think we will want it slightly different to follow the common patterns of chef repos. I am looking into why CI started failing all of a sudden...

majormoses commented 8 years ago

@jkauffman503 I have fixed the CI issues: #21 ...as soon as this is merged please rebase my changes into your branch.

majormoses commented 8 years ago

@jkauffman503 I self merged it as it was only CI fixes. please rebase to make your CI pass

majormoses commented 8 years ago

@jkauffman503 this looks better, are you done making changes if so lets squash those commits down...

majormoses commented 8 years ago

@jkauffman503 any chance you could be done by tomorrow? I would like to merge #22 but I need to add doc and I want to wait until we have made the format solid.

jkauffman503 commented 8 years ago

It'll be done by tomorrow!

Sent using CloudMagic Emailhttps://cloudmagic.com/k/d/mailapp?ct=pa&cv=8.4.40&pv=5.1.1&source=email_footer_2 On Thu, Apr 28, 2016 at 8:02 PM, Ben Abrams notifications@github.com<mailto:notifications@github.com> wrote:

@jkauffman503https://github.com/jkauffman503 any chance you could be done by tomorrow? I would like to merge #22https://github.com/Netuitive/chef-netuitive/pull/22 but I need to add doc and I want to wait until we have made the format solid.

You are receiving this because you were mentioned. Reply to this email directly or view it on GitHubhttps://github.com/Netuitive/chef-netuitive/pull/20#issuecomment-215597506

jkauffman503 commented 8 years ago

Finished rebase and merge with remote. It's a little ugly, but I think it's ready.

majormoses commented 8 years ago

closing this and moving it to: https://github.com/Netuitive/chef-netuitive/pull/23