Network-Goods / hypercerts-docs

https://protocol.github.io/hypercerts-docs/
5 stars 1 forks source link

Add SVG generation contract and generate one SVG based on hypercert data #26

Closed bitbeckers closed 2 years ago

bitbeckers commented 2 years ago
bitbeckers commented 2 years ago
Screenshot 2022-09-29 at 16 21 25

@reasn @holkeb couple of questions:

holkexyz commented 2 years ago

@bitbeckers

  1. Yes, a percentage is actually preferred
  2. Yes, "Research on Infra-Baesianism" is the title and I think we need to limit it in length. I assume we need to limit all fields in length, right? Only exception is the date. Even the percentage could theoretically be too long, ie 0,000000000000000001%, so I would even limit that (just in case)
  3. "AI Existential Safety" is the Scope of Impact
bitbeckers commented 2 years ago
2. Yes, "Research on Infra-Baesianism" is the title and I think we need to limit it in length. I assume we need to limit all fields in length, right? Only exception is the date. Even the percentage could theoretically be too long, ie 0,000000000000000001%, so I would even limit that (just in case)

My proposal would be a percentage up to two decimals: 100,00%

3. "AI Existential Safety" is the Scope of Impact

What is there are multiple scopes of impact? We've built and tested for that, is that not needed? Or otherwise, how to select which one is, or which ones are, displayed?

holkexyz commented 2 years ago

Yes, percentage up to two decimals works. For all use cases that I have in mind this will be ok.

I would concatenate the multiple scopes of impact with a comma in between and then enforce a limit in length. Do we store the multiple scope of impact in the order that the user entered them? If so, that would be my preferred order.

bitbeckers commented 2 years ago

Ok in that case it would be:

For example the scopes of impact would look like:

(You can put more info when using a list instead of concatenating. Especially because the input for scope text is currently free-form)

holkexyz commented 2 years ago

Sounds good, except that makes the data structure in any way weird.

And with the chance of making it more complicated. Something that I have in my mind for later, but maybe it is relevant if you turn the scope of impact into an array:

At some point we might want to add an impact metric, e.g. "tons of CO2e reduced" or "hours of mentorship to high-school students". We could just have a separate variable to store this, but we could also use the scopes of impact, e.g. if the scope of impact is "CO2e reduction in tons" then we could store a quantity with it. Bringing this up because this would then just go into the array, right? Let me know if I'm complicating things too much here now :)

bitbeckers commented 2 years ago

Ehm yeah it already is an array, that enables users to provides the multiple scopes as the app supports now. What you're describing in the simples form is easy: certId -> scopeId -> value

The crux is preventing noisy or impossible data. For instance Elephants saved -> 100000. But, since there are evaluators the alarming for weird input could be front-end logic, the rest is up to the user, evaluator and funder

holkexyz commented 2 years ago

Yes, I would like @davidad's quick input on this, but I think I would enable it on the protocol level and then shift the burden to front-end and evaluators

holkexyz commented 2 years ago

Update: We leave the impact metrics to the evaluation, i.e. if someone wants to claim a specific quantitative impact, it would be a self-evaluation.

bitbeckers commented 2 years ago

Image

The is a cert generated with on chain-data taking into account the updated fonts but more important a name that's long ("TestSVG one two three four five six seven eight") and multiple workscopes (cut-off for first 3).

@holkeb I would say this matches our needs for now, what do you think?

holkexyz commented 2 years ago

Cool! That looks very nice, thank you

I think I wasn't in the room when the latest design of the SVGs where discussed. In figma on the right from the design that you build here, we switched some categories: Top --> Scope of Impact Below name --> Contributors Bottom --> Time of work

I hope this didn't get lost in the communication. If so, and it is lots of work to change, please let me know.

On the name, yes, that is what I had in mind :) I only wonder if we could get a few more characters shown? (e.g. by limiting the text below the name to two lines and adding a fourth line for the name)

bitbeckers commented 2 years ago

Sorry I missed this last note. For reference and whatnot, this is what we'll deploy now

Screenshot 2022-10-13 at 12 53 23