search

Network-Goods / hypercerts-protocol

MIT License
13 stars 5 forks source link

burning / enumeration issues #54

Open elmariachi111 opened 1 year ago

elmariachi111 commented 1 year ago

I put the issues into an PR so it's simpler to describe it in code: https://github.com/Network-Goods/hypercerts-protocol/pull/53

1 (ERC3525) burning nfts implicitly decreases token supply (that's ok but maybe worth another thought) 2 (Enumerable) tokenInSlotByIndex / tokenSupplyInSlot yield wrong values after a value transfer 3 (merging) totalSupply doesn't decrease after merging values.

All details inside the PR's description :)