Network-Goods / hypercerts-protocol

MIT License
13 stars 5 forks source link

Unidentified contract on OpenSea #92

Closed bitbeckers closed 1 year ago

bitbeckers commented 1 year ago

https://testnets.opensea.io/assets/goerli/0xffb1fbff7a40ea441aeae8036812af116f593995/17

Screenshot 2023-01-25 at 12 44 43
julienbrg commented 1 year ago

id #17 displays correctly on OpenSea on my side (the link you provided), but not id #2.

bitbeckers commented 1 year ago

Ah yes, but that's a metadata issue. We focussing on the minting flow first and you can see that the quality of the data ("Properties" field) is way better.

The issue is the reading of the contract name that OpenSea happily skips. I've added a screenshot to the original post

julienbrg commented 1 year ago

Thanks for your reply.

https://stackoverflow.com/questions/68891144/how-to-fix-unidentified-contract-opensea-is-unable-to-understand-erc1155

It seems like OpenSea is still relying on some old implementation of ERC-1155…

Adding a name variable until OpenSea fixes that may be a solution.

bitbeckers commented 1 year ago

Non-issue, contract used was a seperate testing contract. HypercertMinter is represented as expected.

Screenshot 2023-01-25 at 16 06 39