Open bitbeckers opened 1 year ago
@bitbeckers @ryscheng working on this now. Wondering whether we want to provide a formatting utility to the end user as well, as this schema would be pretty cumbersome to format to everytime. We can then format it, and also run validation against the JSON schema in the same function?
It would also help with making sure display_value
properties etc are formatted consistently.
Wondering whether we want to provide a formatting utility to the end user as well, as this schema would be pretty cumbersome to format to everytime. It would also help with making sure
display_value
properties etc are formatted consistently.
@Jipperism agreed. I created a utility in python for rendering (see here) that could be adapted for this purpose
Wondering whether we want to provide a formatting utility to the end user as well, as this schema would be pretty cumbersome to format to everytime. It would also help with making sure
display_value
properties etc are formatted consistently.@Jipperism agreed. I created a utility in python for rendering (see here) that could be adapted for this purpose
Already created my own in the SDK. It might have to be updated once people settle on either "Workscope A & Workscope B" or Workscope A ^ Workscope B" for example.
https://github.com/Network-Goods/hypercerts/issues/98 linking this here
@Jipperism:
Already created my own in the SDK. It might have to be updated once people settle on either "Workscope A & Workscope B" or Workscope A ^ Workscope B" for example.
Agreed. Happy to let @holkeb decide
yes, let's use "workscope A ∧ workscope B"
(note that it's not ^ but ∧)
This is what it looks like on OpenSea: https://testnets.opensea.io/assets/goerli/0xffb1fbff7a40ea441aeae8036812af116f593995/57
Updates:
values
anddisplay_values
to make the intended behavior more explicit (eg, case whereimpact_scope: ["all"]
, showing that multiple scopes are conjunctive)Originally posted by @ccerv1 in https://github.com/Network-Goods/hypercerts/issues/98#issuecomment-1407193885