search

NetworkBlockDevice / nbd

Network Block Device
GNU General Public License v2.0
450 stars 116 forks source link

Fix the "disabled" case of enable_manpages #158

Closed waveform80 closed 5 months ago

waveform80 commented 6 months ago

Currently, running configure --disable-manpages while docbook2man is installed results in the error "don't know what to do here" when it should disable building of manpages (I ran into this when attempting a build on Ubuntu jammy, finding the manpages didn't want to build, and thinking "I'll just disable that for the moment", and then finding I couldn't disable it :).

There also appears to be a missing conditional at the start of the line; there's closing un-matched ]) at the end of the line. Still, at this point the check can be done in pure shell, no need for AC macros. I've also removed the confusing m4_divert_text call on the check case. Not sure why that was there, but it appears unnecessary.

yoe commented 5 months ago

The m4_divert_text stuff is taken from an example in the autotools documentation, but I agree that it's confusing and unnecessary.