search

NetworkBlockDevice / nbd

Network Block Device
GNU General Public License v2.0
459 stars 119 forks source link

Clarify length of NBD_INFO information requests in NBD_OPT_GO/NBD_OPT_INFO #85

Closed nhooyr closed 6 years ago

nhooyr commented 6 years ago

See https://github.com/NetworkBlockDevice/nbd/blob/01188597bfd524d5b87d7cf4c818564dd91a4810/doc/proto.md#option-types

16 bits x n - list of NBD_INFO information requests

Should be

16 bits * number_of_information_requests - list of NBD_INFO information requests

Otherwise its not very clear imo.

yoe commented 6 years ago

disagree (and this is a very tiny thing anyway)

nhooyr commented 6 years ago

using x for multiplication just isn't very common in a programming context, its always *. Given the file is plaintext we should definitely do that change at least.