search

NetworkVerification / nv

A Framework for Modeling and Analyzing Network Configurations
MIT License
31 stars 2 forks source link

Consider changing graph implementation #12

Closed alberdingk-thijm closed 5 years ago

alberdingk-thijm commented 5 years ago

The current nv graph implementation in datastructures/AdjGraph.ml is very basic. I've added a little functionality to allow nodes to be added, but I gradually find myself needing to tack on bits.

I spoke to @princedpw about this and his suggestion was to pull in a more complete OCaml graph library to replace AdjGraph.ml. I'd like to look into the available options and see about replacing the current library with something a little heftier.

nickgian commented 5 years ago

Here's a pointer I've used this in multiple projects, for NV too (fun fact: the module AdjGraph was named Graph initially but clashed with OCamlgraph forcing me to rename it).

alberdingk-thijm commented 5 years ago

@nickgian Yeah, that's what I was thinking we'd use. I'll start a separate branch and hack something together.