search

Networking-for-Arduino / EthernetENC

Ethernet library for ENC28J60. This is a modern version of the UIPEthernet library. EthernetENC library is compatible with all Arduino architectures with Arduino SPI library with transactions support. Only include EthernetENC.h instead of Ethernet.h
127 stars 28 forks source link

-Wsign-compare warning #26

Closed StandaSK closed 2 years ago

StandaSK commented 2 years ago

There is a -Wsign-compare warning in utility/uip.c:

EthernetENC\src\utility\uip.c:856:39: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   if((BUF->len[0] << 8) + BUF->len[1] <= uip_len) {
                                       ^~

Found by enabling all compiler warnings.

JAndrassy commented 2 years ago

this is the 20 years old uip library used in many devices. I leave it as it is.