search

Networking-for-Arduino / EthernetENC

Ethernet library for ENC28J60. This is a modern version of the UIPEthernet library. EthernetENC library is compatible with all Arduino architectures with Arduino SPI library with transactions support. Only include EthernetENC.h instead of Ethernet.h
127 stars 28 forks source link

Request setting custom hostName #49

Open DRSDavidSoft opened 1 year ago

DRSDavidSoft commented 1 year ago

Hi there, currently the hostname is hardcoded to ENC28J + the last three hex digits of the MAC address:

https://github.com/JAndrassy/EthernetENC/blame/master/src/Dhcp.cpp#L195-L201

I was wondering if it could be possible to set it to a custom value? Perhaps something akin to this PR that is for WIZnet's Ethernet.h? https://github.com/arduino-libraries/Ethernet/pull/77

Great work BTW, I'm very impressed by how smooth this chip works. I didn't expect it to perform this good, so I appreciate your great library!

JAndrassy commented 1 year ago

do you want to transfer the change to EthernetENC (it has the same DhcpClass) and submit a PR?