search

Networks-Learning / nevae

Code and data for "NeVAE: A Deep Generative Model for Molecular Graphs", AAAI 2019
54 stars 14 forks source link

Some confusing places #3

Closed odek53r closed 6 years ago

odek53r commented 6 years ago

Hi, I try to run nevae and find something confusing.

  1. In the model.py file, the get_lossfunc function only contains KL and likelihood losses, but the paper states that there are four losses including KL, likelihood, log(pλn), log(pλm). Should I need to implement log(pλn) and log(pλm) by myself?

  2. In the model.py file, the implementation of masked_gen function is a little bit complex, so I can't understand it clearly. Could you give me some related papers or information to read?

  3. In the utils.py file, the code of line 135 is edgelist which appends same all edges of compound graph many times in the loop of G.nodes(). I think that line135 should be put outside the scope of loop of G.nodes() to avoid duplicate contents. If I make mistakes, please let me know.

Thank you for your patience to read my questions. I'll appreciate it if anyone can answer my questions.

odek53r commented 6 years ago

I find answers in other branches, so I close this issue.