search

NeunEinser / bingo

A custom item fetch gamemode for Minecraft
MIT License
84 stars 16 forks source link

Lockout mode does not properly keep track of collected items #183

Closed bl4ckscor3 closed 1 year ago

bl4ckscor3 commented 1 year ago

If a team collects an item, the game announces that to the chat and correctly shows the team who got the item on the card. If another team then collects that same item, the game still announces that in chat, even though it is no longer relevant for the end result. This also leads to a skewed total items count and incorrectly declaring someone as the winner.

This screenshot shows the same item being collected by two teams

This causes the actual first collected item by the green team being shown as the second item in chat...

...and ultimately leading to the green team being declared the winner with only 12 actual collected items

Full log of the game [15:47:49] [Render thread/INFO]: [System] [CHAT] 3 [15:47:50] [Render thread/INFO]: [System] [CHAT] 2 [15:47:51] [Render thread/INFO]: [System] [CHAT] 1 [15:47:52] [Render thread/INFO]: [System] [CHAT] GO! [15:47:52] [Render thread/INFO]: [System] [CHAT] Click here to go back to the lobby.\nClick here to switch to spectator mode. [15:47:52] [Render thread/INFO]: [System] [CHAT] Hint: You can click [?] anywhere to bring up the Fetchr menu. You may also run /trigger fetchr. manually, replacing with the auto-completable action. [15:47:56] [Render thread/INFO]: [System] [CHAT] [?] [4.15 | #1] bl4ckscor3 got [Flint and Steel] [15:47:56] [Render thread/INFO]: [System] [CHAT] 24 [15:47:57] [Render thread/INFO]: [System] [CHAT] [?] [5.60 | #1] Redstone_Dubstep got [Flint and Steel] [15:47:57] [Render thread/INFO]: [System] [CHAT] 23 [15:48:01] [Render thread/INFO]: [CHAT] wait what [15:49:00] [Render thread/INFO]: [System] [CHAT] [?] [1:08.65 | #2] bl4ckscor3 got [Hay Bale] [15:49:00] [Render thread/INFO]: [System] [CHAT] 23 [15:50:12] [Render thread/INFO]: [System] [CHAT] [?] [2:20.35 | #2] Redstone_Dubstep got [Spruce Sapling] [15:50:12] [Render thread/INFO]: [System] [CHAT] 22 [15:50:50] [Render thread/INFO]: [System] [CHAT] [?] [2:58.45 | #3] Redstone_Dubstep got [Raw Salmon] [15:50:50] [Render thread/INFO]: [System] [CHAT] 21 [15:51:05] [Render thread/INFO]: [System] [CHAT] [?] [3:13.80 | #4] Redstone_Dubstep got [Snow] [15:51:05] [Render thread/INFO]: [System] [CHAT] 20 [15:52:45] [Render thread/INFO]: [CHAT] lol [15:52:46] [Render thread/INFO]: [System] [CHAT] [?] [4:54.05 | #3] bl4ckscor3 got [Emerald] [15:52:46] [Render thread/INFO]: [System] [CHAT] 19 [15:53:37] [Render thread/INFO]: [System] [CHAT] [?] [5:45.31 | #5] Redstone_Dubstep got [Fern] [15:53:37] [Render thread/INFO]: [System] [CHAT] 18 [15:54:15] [Render thread/INFO]: [System] [CHAT] [?] [6:23.35 | #6] Redstone_Dubstep got [Green Dye] [15:54:15] [Render thread/INFO]: [System] [CHAT] 17 [15:54:36] [Render thread/INFO]: [System] [CHAT] [?] [6:44.65 | #7] Redstone_Dubstep got [Muddy Mangrove Roots] [15:54:36] [Render thread/INFO]: [System] [CHAT] 16 [15:55:09] [Render thread/INFO]: [System] [CHAT] [?] [7:17.75 | #4] bl4ckscor3 got [Minecart with Furnace] [15:55:09] [Render thread/INFO]: [System] [CHAT] 15 [15:56:02] [Render thread/INFO]: [System] [CHAT] [?] [8:10.41 | #8] Redstone_Dubstep got [Emerald] [15:56:02] [Render thread/INFO]: [System] [CHAT] 14 [15:56:08] [Render thread/INFO]: [CHAT] uh ops [15:56:25] [Render thread/INFO]: [System] [CHAT] [?] [8:33.70 | #9] Redstone_Dubstep got [Block of Iron] [15:56:25] [Render thread/INFO]: [System] [CHAT] 14 [15:57:16] [Render thread/INFO]: [System] [CHAT] [?] [9:24.75 | #10] Redstone_Dubstep got [Stonecutter] [15:57:16] [Render thread/INFO]: [System] [CHAT] 13 [15:57:54] [Render thread/INFO]: [System] [CHAT] [?] [10:02.76 | #5] bl4ckscor3 got [Milk Bucket] [15:57:54] [Render thread/INFO]: [System] [CHAT] 12 [15:58:25] [Render thread/INFO]: [System] [CHAT] [?] [10:33.61 | #11] Redstone_Dubstep got [Sea Pickle] [15:58:25] [Render thread/INFO]: [System] [CHAT] 11 [15:58:47] [Render thread/INFO]: [System] [CHAT] [?] [10:55.21 | #12] Redstone_Dubstep got [Firework Rocket] [15:58:47] [Render thread/INFO]: [System] [CHAT] 10 [15:59:04] [Render thread/INFO]: [System] [CHAT] [?] [11:12.00 | #6] bl4ckscor3 got [Minecart with Hopper] [15:59:04] [Render thread/INFO]: [System] [CHAT] 9 [15:59:54] [Render thread/INFO]: [System] [CHAT] [?] [12:01.96 | #13] Redstone_Dubstep got [Gray Dye] [15:59:54] [Render thread/INFO]: [System] [CHAT] 8 [16:02:05] [Render thread/INFO]: [System] [CHAT] [?] [14:13.51 | #14] Redstone_Dubstep got [Crossbow] [16:02:05] [Render thread/INFO]: [System] [CHAT] 7 [16:02:05] [Render thread/INFO]: [System] [CHAT] [?] [14:13.51] Redstone_Dubstep won the lockout race!
NeunEinser commented 1 year ago

Hmm that's weird, will look into it, thanks!

It should fail the item detection code completely. If it announces it in chat, the item actually counts for both teams as well as if this is a normal game.

NeunEinser commented 1 year ago

Oh, also the numbers you see there after each announcement are a left over debug thing, they shouldn't be in the release 🙈