NeunEinser / bingo

A custom item fetch gamemode for Minecraft
MIT License
84 stars 16 forks source link

Spawning over flowing lava, leading to potential death loop #210

Closed davepusey closed 6 months ago

davepusey commented 1 year ago

Minecraft 1.20.1 Fetchr 5.1.1 (originally discovered in 5.1-pre1) Seed 1277800318

Spawning (and respawning after death) over flowing lava can potentially lead to a death loop, or starting with very low health.

See video example below.

https://youtu.be/8Mcd8QzT6GM

And snippet from Phedran's stream (Sat 26th August 2023) where we originally encountered this issue in 5.1-pre1

https://youtu.be/_l6EkyKLGL8

Managed to "fix" it during that stream by going into creative mode, flying onto the safe land beside the original spawn point, and then manually set the spawn point using /setworldspawn command.

NeunEinser commented 1 year ago

Thanks for the report!

In case your worldspawn is still at that location on that server, you should run execute in overworld run setworldspawn 0 0, otherwise this will break things in consecutive games, as respawning is not managed by setting world spawn and the map expects the spawnpoint to always be at 0 0 in the overworld dimension (which btw is a different dimension from the one games take place).

If something like this happens again, either just generate a different card, or fix it by e.g. manually covering the lava with dirt.

davepusey commented 1 year ago

My server has been reloaded with a newer version since that original incidient on stream, so no issues there.

This was more a report so that a proper solution/handler could be implemented into Fetchr itself.

davepusey commented 1 year ago

And yes, current workaround is to check for lava before starting and generating a new card if found.

NeunEinser commented 1 year ago

Yes, of course, this is definitely something that needs to be fixed in the game itself 😉

NeunEinser commented 1 year ago

And also thanks for providing the examples, videos, and the seed, very well made report 💜

NeunEinser commented 6 months ago

Fixed by 72ee2de33804a8e802fd520f1f8d64dfafb9a5d9.

Github should have auto closed, not sure why not.

davepusey commented 5 months ago

Confirmed working in 5.1.2-rc1 on 1.20.5-pre1