search

NeuraLegion / sectester-js

SecTester is a new tool that integrates our enterprise-grade scan engine directly into your unit tests.
MIT License
5 stars 4 forks source link

feat(bus): get rid of amqp event bus #198

Closed ostridm closed 4 months ago

ostridm commented 5 months ago

closes #196

gitguardian[bot] commented 5 months ago

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [11416025](https://dashboard.gitguardian.com/workspace/550753/incidents/11416025?occurrence=146027607) | Triggered | Generic Password | afadab5a05f046401c901fe5ce301767f02893f1 | packages/bus/src/dispatchers/DefaultRMQConnectionManager.spec.ts | [View secret](https://github.com/NeuraLegion/sectester-js/commit/afadab5a05f046401c901fe5ce301767f02893f1#diff-5e94aa4666d3b2718cfc70cb61c79f77450cc44e1e753a3eca09a43b3512bfdcL77) | | [11416025](https://dashboard.gitguardian.com/workspace/550753/incidents/11416025?occurrence=146027608) | Triggered | Generic Password | afadab5a05f046401c901fe5ce301767f02893f1 | packages/bus/src/dispatchers/DefaultRMQConnectionManager.spec.ts | [View secret](https://github.com/NeuraLegion/sectester-js/commit/afadab5a05f046401c901fe5ce301767f02893f1#diff-5e94aa4666d3b2718cfc70cb61c79f77450cc44e1e753a3eca09a43b3512bfdcL91) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

derevnjuk commented 4 months ago

@ostridm please rebase onto the main

codeclimate[bot] commented 4 months ago

Code Climate has analyzed commit a307ed1f and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.3%.

View more on Code Climate.